4.0.0 release #257
4.0.0 release #257
Conversation
| end | ||
|
|
||
| def set_cluster_name(resource_name) # rubocop:disable AccessorMethodName | ||
| ChefSpec::Matchers::ResourceMatcher.new(:rabbitmq_cluster, :change_cluster_node_type, resource_name) |
There was a problem hiding this comment.
Humm, this looks like a typo, should be :set_cluster_name as 2nd parm?
There was a problem hiding this comment.
Nope, it looks like it's referenced as :change_cluster_node_type
| @@ -32,6 +32,16 @@ class Chef::Resource # rubocop:disable all | |||
| # logrotate is a package dependency of rabbitmq-server | |||
| package 'logrotate' | |||
|
|
|||
| # dpkg, imma let you finish but don't start services automatically | |||
| # https://jpetazzo.github.io/2013/10/06/policy-rc-d-do-not-start-services-automatically/ | |||
There was a problem hiding this comment.
Is this hack same on all platforms?
There was a problem hiding this comment.
It's in the debian family section. Line 31
There was a problem hiding this comment.
Correct, the hack will only apply to debian platform_families although other commits in that PR do fix the root issue on both RHEL and Debian platform_families
|
Added some minor comments. With this new lwrp, certainly seems like this could be a 4.x release, but if this new lwrp is not used in default path, it could be justified as just a minor enhancement. |
|
With rolling in the clustering cookbook i feel justified on the 4.x release, if i can get someone other than me verify that |
This has a ton of changes and feature requests.
I'm betting it's a Major release, but i'd like some feedback.