Add more chefspec tests #193
Conversation
|
@wenchma it looks like we got some travis failures. |
|
I think this is in reference to something like this: https://github.com/jjasghar/rabbitmq/pull/168/files#diff-55bf87238c9b8af164c5133a60721f12R169 |
|
@wenchma I tried fixing these errors, couldnt fix it :(. Can you rip out those tests, so we can get this merged in? |
|
updated the PR for spec tests |
6beb17c to
a15f343
Compare
|
~/rabbitmq$ rspec spec/ Finished in 1 minute 28.43 seconds (files took 4.51 seconds to load) ChefSpec Coverage report generated... Total Resources: 23 You are awesome and so is your test coverage! Have a fantastic day! |
|
@jjasghar success to run rspec on my local env, but the travis CI build failed, it confused me. |
|
Man, i try it on my local box, checking out your branch, and i get errors all over the place. are you running this on a box with rabbitmq installed on it? I'm not and i'm seeing errors. I'm gonna close the issue #190 so we have the conversation in one place. |
|
@wenchma can you rebase this guy and see if travis'll pass now? I think i've fixed things upstream. |
|
@jjasghar Ok. I will rebase it and update the PR |
|
have updated the PR, and the coverage result: ChefSpec Coverage report generated... Total Resources: 23 You are awesome and so is your test coverage! Have a fantastic day! |
Add some missing spec tests to cover more chef resources, but it reports some same untouched resources repeatedly for many times. Fixes issue rabbitmq#190
Add some missing spec tests to cover more chef resources,
but it reports some same untouched resources repeatedly
for many times.
Fixes issue #190