-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports setting rabbitmq config file to a different path #184
Conversation
The Travis CI build failed is not related with this change, it looks like other errors: |
@wenchma you should be able to just run They look like all the same thing over and over, so the |
@jjasghar added a spec for this PR |
|
||
describe 'different path' do | ||
before do | ||
node.set['rabbitmq']['config'] = '/path/to/rabbitmq' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about below?
let(:runner) { ChefSpec::ServerRunner.new(REDHAT_OPTS) }
let(:node) { runner.node }
let(:chef_run) do
node.set['rabbitmq']['config'] = '/path/to/rabbitmq'
runner.converge(described_recipe)
end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wenchma I like this, it's consistant with the other specs also. Thanks @stevecstian
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the above doesn't cover the default attribute, but also looks good to me !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wenchma Will you go with "setting attribute in let(:chef_run)
block"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevecstian yes, will do it.
👍 |
Supports setting rabbitmq config file to a different path
issue #157
Fixes issue #157