Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run tests with race detector #74

Merged
merged 3 commits into from
Apr 19, 2022

Conversation

fho
Copy link
Contributor

@fho fho commented Apr 19, 2022

ci: enable the race detector when running go tests

Pass "-race" when running the tests via the Makefile or in CI.
This enables the race detector and can catch some bugs.

-------------------------------------------------------------------------------
make: define all targets as phony

This prevents that Make skips running a target if a file with the same
name then target exist.

fho added 2 commits April 19, 2022 17:17
This prevents that Make skips running a target if a file with the same
name then target exist.
Pass "-race" when running the tests via the Makefile or in CI.
This enables the race detector and can catch some bugs.
@fho fho changed the title Ci run tests with race detector ci: run tests with race detector Apr 19, 2022
@lukebakken lukebakken self-assigned this Apr 19, 2022
@lukebakken lukebakken added this to the 1.3.5 milestone Apr 19, 2022
@lukebakken lukebakken merged commit 032e1fe into rabbitmq:main Apr 19, 2022
@fho
Copy link
Contributor Author

fho commented Apr 19, 2022

@lukebakken I now realized that project also has a github actions config which is used.
So "-race" also needs to be added when running tests via github actions.

Is travis CI also used somehow? Or could the config be removed?

@lukebakken
Copy link
Contributor

Oh, good catch. I forgot we're not using the make target for GitHub actions.

Yes, please feel free to remove the .travis.yml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants