Add constants for Queue arguments #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Queues accept optional arguments during queue declaration. Most of those arguments can be set using a policy (recommended), however, queue type must be set at queue declaration. To pave the way for Quorum and Stream queue adoption, this commit adds constants to easily set the queue type. Other common used arguments are part of this commit. Additional queue arguments can be added as needed/requested by the community. Signed-off-by: Aitor Pérez Cedres <acedres@vmware.com>
lukebakken
approved these changes
Dec 22, 2022
There was a problem hiding this comment.
I made one small change. I realize it's not necessary but it caught me by surprise that it worked (https://go.dev/ref/spec#Constant_declarations)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queues accept optional arguments during queue declaration. Most of those
arguments can be set using a policy (recommended), however, queue type
must be set at queue declaration. To pave the way for Quorum and Stream
queue adoption, this commit adds constants to easily set the queue type.
Other common used arguments are part of this commit. Additional queue
arguments can be added as needed/requested by the community.