Adds new component that allows user to specify .spiceinit contents. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, surely it could be useful. I will try to test it in the next days. |
I open an exisitng icon with KolorPaint or another such software and edit it. Yes can use .OPTIONS icon and replace the text. GIMP is overkill for such task. |
|
Added an icon for the new component. PTAL. |
|
I have tested it. The XSPICE compatibility seems not to be broken. I have found no further problems with the new component. |
|
Are you planning to add some new features for this |
|
I was not planning to add any new features for this new component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new SPICE-only component (SPICEINIT), that users can use to specify .spiceinit contents. For this component, a new dialog was created, which allows editing a single text box (used in this case for the contents of the spiceinit file), and could potentially be reused for other purposes.
The new component, SPICEINIT, is only used in the ngspice simulator class. Other simulators, like Xyce, ignore this new component. For ngspice simulator, the specified contents of spiceinit are forwarded to the XSPICE_CMbuilder class, which is currently in charge of creating the spiceinit file. This is a bit unfortunate, as it would be cleaner if the responsibility of creating spiceinit was kept by Ngspice class.
Still to do, create an icon for the new component as it currently is reusing sp_options.png. BTW, how do you create those icons? I'm afraid if I try to do it manually with GIMP or something it will not look the same style as the other icons.
Screenshot displaying how it shows in the component selector and the schematics:
Fixes #25