Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change .OPTIONS and .FUNC components to allow free editing of contents. #1262

Open
wants to merge 1 commit into
base: current
Choose a base branch
from

Conversation

iwbnwif
Copy link
Contributor

@iwbnwif iwbnwif commented Feb 28, 2025

Potential fix for #1260.

@iwbnwif
Copy link
Contributor Author

iwbnwif commented Feb 28, 2025

I have assumed that these dialogs should not have the "Simulation" and "Put result in dataset" options.

@ra3xdh
Copy link
Owner

ra3xdh commented Feb 28, 2025

I have assumed that these dialogs should not have the "Simulation" and "Put result in dataset" options.

Yes, the both components should not have these properties.

The .OPTIONS has another problem. The first property of this component XyceOptionPackage should be excluded from the free editing. It is unclear how to process this device with the new dialog. The solution may be to put a QLineEdit holding the first property. The disadvantage of this solution is that it serves only for .OPTIONS device.

@ra3xdh ra3xdh linked an issue Feb 28, 2025 that may be closed by this pull request
@iwbnwif
Copy link
Contributor Author

iwbnwif commented Mar 1, 2025

Please can you point me any docs on the function of XyceOptionPackage and how it affects the simukation or other options.

One solution might be to create a separate component that holds this value pair. This has the advantage of only being visible in the pallette (and greyed in the schematic) when Xyce is active as the simulation engine.

@ra3xdh
Copy link
Owner

ra3xdh commented Mar 1, 2025

The usage of .OPTIONS could be found in Xyce Reference guide, chapter 2.1.25 https://xyce.sandia.gov/files/xyce/Xyce_Reference_Guide_7.6.pdf

I am considering to deprecate the both .OPTIONS and .FUNC components as redundant. After introduction of free editing the purpose of these devices is duplicated by include script.

@iwbnwif
Copy link
Contributor Author

iwbnwif commented Mar 1, 2025

Thank you for the link.

Sorry, I am missing the problem here. If I enter the following in the Options dialog, a valid netlist appears to be generated. Unfortunately, my Xyce installation is broken at the moment, so I can't test if it actually simulates.

image

Netlist snip:

.PARAM dBS21={dB(S[2,1])}
.PARAM dBS11={dB(S[1,1])}
.OPTIONS TIMEINT  ABSTOL = 1E-8 

So the netlist appears to be the same as the example in the Xyce reference guide section 2.1.25.

@ra3xdh
Copy link
Owner

ra3xdh commented Mar 1, 2025

Sorry, I am missing the problem here.

The user may modify the name (XyceOptionPackage) of the first property or event delete the first property by accident. The netlist will be wrong in such case. The first property should be with fixed name and always present. The solution may be to add validation and warning if the user press OK. The validation must be done only for .OPTIONS device.

@iwbnwif
Copy link
Contributor Author

iwbnwif commented Mar 2, 2025

Thank you for the explanation. It may be a few days before I can look at this again but hopefully that isn't too inconvenient as there is a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Options: Unable to add/modify .OPTIONS parameters
2 participants