Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in NEUS datetime #23

Closed
bselden opened this issue Dec 4, 2015 · 8 comments
Closed

Error in NEUS datetime #23

bselden opened this issue Dec 4, 2015 · 8 comments

Comments

@bselden
Copy link
Collaborator

bselden commented Dec 4, 2015

The last two digits of CRUISE6 in raw.neus do NOT appear to encode the correct sampling month.

In the surveys labeled "fall", the month that is calculated using those last two digits implies that sampling occurs every month except January and February.

I checked this against the raw data for cod from the trawl survey available on the OBIS website http://www.iobis.org/mapper/?dataset=1435, and found that the monthcollected for the fall survey only included September-December, suggesting that there is an error in the way that datetime is calculated for neus files in the trawlData package

Code highlighting the discrepancy between the months sampled in clean.neus and the cod OBIS data file is attached below, as is the cod OBIS data file itself.

@bselden
Copy link
Collaborator Author

bselden commented Dec 4, 2015

@bselden
Copy link
Collaborator Author

bselden commented Dec 7, 2015

Look up file for trawlData haulid (haulid.RB), that created by Malin (haulid.MP), and the date of the haul for spring NEUS trawls 1968-2008
https://gist.github.com/bselden/e07a98667b02feefa50e

@rBatt
Copy link
Owner

rBatt commented Dec 14, 2015

@mpinsky we need to ask Lucey for month and day columns next time

@mpinsky
Copy link
Collaborator

mpinsky commented Dec 14, 2015

He's been responsive in the past. We could ask him tomorrow if we wanted.

What's the error? He sent date in his last update.

On Sunday, December 13, 2015, Ryan Batt notifications@github.com wrote:

@mpinsky https://github.com/mpinsky we need to ask Lucey for month and
day columns next time


Reply to this email directly or view it on GitHub
#23 (comment).

Please excuse, sent from a device with tiny keys...

@rBatt
Copy link
Owner

rBatt commented Dec 14, 2015

Old code had inferred date from last digits of CRUISE6 column. However, comparing to other online data source, @bselden has found that the inference is wrong.

I don't think it was my original code that clipped out from cruise6, but there's a chance it was.

@mpinsky
Copy link
Collaborator

mpinsky commented Dec 14, 2015

Does the new date column in the NEUS data solve this problem?

On Sun, Dec 13, 2015 at 11:12 PM, Ryan Batt notifications@github.com
wrote:

Old code had inferred date from last digits of CRUISE6 column. However,
comparing to other online data source, @bselden
https://github.com/bselden has found that the inference is wrong.

I don't think it was my original code that clipped out from cruise6,
but there's a chance it was.


Reply to this email directly or view it on GitHub
#23 (comment).

@rBatt
Copy link
Owner

rBatt commented Dec 14, 2015

I'll check that. I was intending to work on trawlData today anyway.

On Monday, December 14, 2015, mpinsky notifications@github.com wrote:

Does the new date column in the NEUS data solve this problem?

On Sun, Dec 13, 2015 at 11:12 PM, Ryan Batt <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');>
wrote:

Old code had inferred date from last digits of CRUISE6 column. However,
comparing to other online data source, @bselden
https://github.com/bselden has found that the inference is wrong.

I don't think it was my original code that clipped out from cruise6,
but there's a chance it was.


Reply to this email directly or view it on GitHub
#23 (comment).


Reply to this email directly or view it on GitHub
#23 (comment).

rBatt added a commit that referenced this issue Dec 15, 2015
@rBatt
Copy link
Owner

rBatt commented Dec 15, 2015

I think 39f2c94 fixed this; I haven't tested by making sure it all runs through OK, but @mpinsky is right that the new column is definitely there

@rBatt rBatt closed this as completed in 39f2c94 Dec 17, 2015
rBatt added a commit that referenced this issue Jul 17, 2016
@bselden you weren't using this still, were you?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants