Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade stable2409 #412

Merged
merged 20 commits into from
Dec 31, 2024

chore: add server feature back to jsonrpsee dep

3a9b9da
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

chore: upgrade stable2409 #412

chore: add server feature back to jsonrpsee dep
3a9b9da
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Dec 29, 2024 in 3s

clippy

233 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 233
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a6 2024-11-26)

Annotations

Check warning on line 599 in integration-tests/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for the crate

warning: missing documentation for the crate
   --> integration-tests/src/lib.rs:1:1
    |
1   | / #![cfg(test)]
2   | |
3   | | use asset_test_utils::xcm_helpers;
4   | | use chains::{
...   |
598 | |     });
599 | | }
    | |_^
    |
    = note: requested on the command line with `-W missing-docs`

Check warning on line 44 in node/src/cli.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

large size difference between variants

warning: large size difference between variants
  --> node/src/cli.rs:5:1
   |
5  | / pub enum Subcommand {
6  | |     /// Build a chain specification.
7  | |     BuildSpec(sc_cli::BuildSpecCmd),
...  |
19 | |     ImportBlocks(sc_cli::ImportBlocksCmd),
   | |     ------------------------------------- the second-largest variant contains at least 240 bytes
...  |
39 | |     Benchmark(frame_benchmarking_cli::BenchmarkCmd),
   | |     ----------------------------------------------- the largest variant contains at least 568 bytes
...  |
43 | |     Key(sc_cli::KeySubcommand),
44 | | }
   | |_^ the entire enum is at least 568 bytes
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
   = note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
   |
39 |     Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
   |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 31 in node/src/rpc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `backend` is never read

warning: field `backend` is never read
  --> node/src/rpc.rs:31:6
   |
25 | pub struct FullDeps<C, P, B> {
   |            -------- field in this struct
...
31 |     pub backend: Arc<B>,
   |         ^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 1030 in runtime/testnet/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a function

warning: missing documentation for a function
    --> runtime/testnet/src/lib.rs:683:1
     |
683  | / impl_runtime_apis! {
684  | |
685  | |     impl sp_consensus_aura::AuraApi<Block, AuraId> for Runtime {
686  | |         fn slot_duration() -> sp_consensus_aura::SlotDuration {
...    |
1029 | |     }
1030 | | }
     | |_^
     |
     = note: this warning originates in the macro `impl_runtime_apis` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 128 in runtime/testnet/src/config/xcm.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
   --> runtime/testnet/src/config/xcm.rs:128:1
    |
128 | pub struct XcmConfig;
    | ^^^^^^^^^^^^^^^^^^^^

Check warning on line 126 in runtime/testnet/src/config/xcm.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
   --> runtime/testnet/src/config/xcm.rs:126:1
    |
126 | pub type TrustedReserves = (NativeAsset, NativeAssetFrom<AssetHub>);
    | ^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 101 in runtime/testnet/src/config/xcm.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
   --> runtime/testnet/src/config/xcm.rs:101:1
    |
101 | pub type Barrier = TrailingSetTopicAsId<(
    | ^^^^^^^^^^^^^^^^

Check warning on line 94 in runtime/testnet/src/config/xcm.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/xcm.rs:94:1
   |
94 | pub struct ParentOrParentsExecutivePlurality;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 274 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-38.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/xcm.rs:87:1
   |
87 | / parameter_types! {
88 | |     // One XCM operation is 1_000_000_000 weight - almost certainly a conservative estimate.
89 | |     pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 64 * 1024);
90 | |     pub const MaxInstructions: u32 = 100;
91 | |     pub const MaxAssetsIntoHolding: u32 = 64;
92 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 274 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-38.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/xcm.rs:87:1
   |
87 | / parameter_types! {
88 | |     // One XCM operation is 1_000_000_000 weight - almost certainly a conservative estimate.
89 | |     pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 64 * 1024);
90 | |     pub const MaxInstructions: u32 = 100;
91 | |     pub const MaxAssetsIntoHolding: u32 = 64;
92 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 286 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-38.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/xcm.rs:87:1
   |
87 | / parameter_types! {
88 | |     // One XCM operation is 1_000_000_000 weight - almost certainly a conservative estimate.
89 | |     pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 64 * 1024);
90 | |     pub const MaxInstructions: u32 = 100;
91 | |     pub const MaxAssetsIntoHolding: u32 = 64;
92 | | }
   | |_^
   |
   = note: this warning originates in the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 286 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-38.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/xcm.rs:28:1
   |
28 | / parameter_types! {
29 | |     pub const RelayLocation: Location = Location::parent();
30 | |     pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
31 | |     // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
...  |
36 | |     pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
37 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 274 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-38.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/xcm.rs:28:1
   |
28 | / parameter_types! {
29 | |     pub const RelayLocation: Location = Location::parent();
30 | |     pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
31 | |     // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
...  |
36 | |     pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
37 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 286 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-38.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/xcm.rs:28:1
   |
28 | / parameter_types! {
29 | |     pub const RelayLocation: Location = Location::parent();
30 | |     pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
31 | |     // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
...  |
36 | |     pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
37 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 274 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-38.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/xcm.rs:28:1
   |
28 | / parameter_types! {
29 | |     pub const RelayLocation: Location = Location::parent();
30 | |     pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
31 | |     // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
...  |
36 | |     pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
37 | | }
   | |_^
   |
   = note: this warning originates in the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 100 in runtime/testnet/src/config/assets.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
   --> runtime/testnet/src/config/assets.rs:100:1
    |
100 | pub type TrustBackedAssetsCall = pallet_assets::Call<Runtime, TrustBackedAssetsInstance>;
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 286 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-38.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:73:1
   |
73 | / parameter_types! {
74 | |     pub const NftFractionalizationPalletId: PalletId = PalletId(*b"fraction");
75 | |     pub NewAssetSymbol: BoundedVec<u8, AssetsStringLimit> = (*b"FRAC").to_vec().try_into().unwrap();
76 | |     pub NewAssetName: BoundedVec<u8, AssetsStringLimit> = (*b"Frac").to_vec().try_into().unwrap();
77 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 286 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-38.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:73:1
   |
73 | / parameter_types! {
74 | |     pub const NftFractionalizationPalletId: PalletId = PalletId(*b"fraction");
75 | |     pub NewAssetSymbol: BoundedVec<u8, AssetsStringLimit> = (*b"FRAC").to_vec().try_into().unwrap();
76 | |     pub NewAssetName: BoundedVec<u8, AssetsStringLimit> = (*b"Frac").to_vec().try_into().unwrap();
77 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 274 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-38.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:73:1
   |
73 | / parameter_types! {
74 | |     pub const NftFractionalizationPalletId: PalletId = PalletId(*b"fraction");
75 | |     pub NewAssetSymbol: BoundedVec<u8, AssetsStringLimit> = (*b"FRAC").to_vec().try_into().unwrap();
76 | |     pub NewAssetName: BoundedVec<u8, AssetsStringLimit> = (*b"Frac").to_vec().try_into().unwrap();
77 | | }
   | |_^
   |
   = note: this warning originates in the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 274 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-38.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:30:1
   |
30 | / parameter_types! {
31 | |     pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | |     pub const NftsCollectionDeposit: Balance = 10 * UNIT;
33 | |     pub const NftsItemDeposit: Balance = UNIT / 100;
...  |
37 | |     pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
38 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 274 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-38.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:30:1
   |
30 | / parameter_types! {
31 | |     pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | |     pub const NftsCollectionDeposit: Balance = 10 * UNIT;
33 | |     pub const NftsItemDeposit: Balance = UNIT / 100;
...  |
37 | |     pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
38 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 274 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-38.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:30:1
   |
30 | / parameter_types! {
31 | |     pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | |     pub const NftsCollectionDeposit: Balance = 10 * UNIT;
33 | |     pub const NftsItemDeposit: Balance = UNIT / 100;
...  |
37 | |     pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
38 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 274 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-38.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:30:1
   |
30 | / parameter_types! {
31 | |     pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | |     pub const NftsCollectionDeposit: Balance = 10 * UNIT;
33 | |     pub const NftsItemDeposit: Balance = UNIT / 100;
...  |
37 | |     pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
38 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 274 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-38.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:30:1
   |
30 | / parameter_types! {
31 | |     pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | |     pub const NftsCollectionDeposit: Balance = 10 * UNIT;
33 | |     pub const NftsItemDeposit: Balance = UNIT / 100;
...  |
37 | |     pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
38 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 274 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-38.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:30:1
   |
30 | / parameter_types! {
31 | |     pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | |     pub const NftsCollectionDeposit: Balance = 10 * UNIT;
33 | |     pub const NftsItemDeposit: Balance = UNIT / 100;
...  |
37 | |     pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
38 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)