refactor: tests #405
Merged
refactor: tests #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
pallets/nfts/src/tests.rs
Outdated
| assert_ok!(approve_collection_transfer( | ||
| origin.clone(), | ||
| maybe_item_owner.clone(), | ||
| for deadline in [None, None, Some(deadline), Some(deadline * 2), Some(deadline), None] { |
There was a problem hiding this comment.
Sorry but I don't understand what this means.
There was a problem hiding this comment.
see latest commit
There was a problem hiding this comment.
This is sadly still not easy to understand. Can we use System::set_block_number(0) to reset the time and update the list of deadlines to fit with that?
There was a problem hiding this comment.
See latest commit
chungquantin
requested changes
Dec 13, 2024
pallets/nfts/src/tests.rs
Outdated
| assert_ok!(approve_collection_transfer( | ||
| origin.clone(), | ||
| maybe_item_owner.clone(), | ||
| for deadline in [None, None, Some(deadline), Some(deadline * 2), Some(deadline), None] { |
There was a problem hiding this comment.
This is sadly still not easy to understand. Can we use System::set_block_number(0) to reset the time and update the list of deadlines to fit with that?
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## chungquantin/feat-nfts #405 +/- ##
==========================================================
- Coverage 70.44% 70.35% -0.09%
==========================================================
Files 70 70
Lines 13109 13073 -36
Branches 13109 13073 -36
==========================================================
- Hits 9234 9197 -37
Misses 3603 3603
- Partials 272 273 +1
|
chungquantin
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.