Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nfts): rebase feat-nfts branch to fix clippy warnings #392

Merged

Conversation

chungquantin
Copy link
Collaborator

No description provided.

@chungquantin chungquantin changed the title fix(nfts): fix clippy warnings fix(nfts): rebase feat-nfts branch to fix clippy warnings Nov 21, 2024
@chungquantin chungquantin self-assigned this Nov 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 78.64078% with 22 lines in your changes missing coverage. Please review.

Project coverage is 69.62%. Comparing base (69dd5f8) to head (a6b0c98).

Files with missing lines Patch % Lines
pallets/nfts/src/impl_nonfungibles.rs 0.00% 8 Missing ⚠️
pallets/nfts/src/features/create_delete_item.rs 89.36% 0 Missing and 5 partials ⚠️
pallets/nfts/src/lib.rs 54.54% 4 Missing and 1 partial ⚠️
pallets/nfts/src/features/approvals.rs 66.66% 0 Missing and 2 partials ⚠️
...lets/nfts/src/features/create_delete_collection.rs 83.33% 0 Missing and 1 partial ⚠️
pallets/nfts/src/features/transfer.rs 88.88% 0 Missing and 1 partial ⚠️
@@                    Coverage Diff                     @@
##           chungquantin/feat-nfts     #392      +/-   ##
==========================================================
+ Coverage                   69.59%   69.62%   +0.02%     
==========================================================
  Files                          69       69              
  Lines                       12222    12212      -10     
  Branches                    12222    12212      -10     
==========================================================
- Hits                         8506     8502       -4     
+ Misses                       3448     3443       -5     
+ Partials                      268      267       -1     
Files with missing lines Coverage Δ
pallets/nfts/src/benchmarking.rs 85.71% <100.00%> (ø)
pallets/nfts/src/common_functions.rs 73.07% <100.00%> (ø)
pallets/nfts/src/features/atomic_swap.rs 90.51% <100.00%> (ø)
...lets/nfts/src/features/create_delete_collection.rs 83.87% <83.33%> (ø)
pallets/nfts/src/features/transfer.rs 85.51% <88.88%> (-0.10%) ⬇️
pallets/nfts/src/features/approvals.rs 90.58% <66.66%> (-0.11%) ⬇️
pallets/nfts/src/features/create_delete_item.rs 89.89% <89.36%> (-0.16%) ⬇️
pallets/nfts/src/lib.rs 72.34% <54.54%> (+0.27%) ⬆️
pallets/nfts/src/impl_nonfungibles.rs 22.38% <0.00%> (+0.32%) ⬆️

🚨 Try these New Features:

@chungquantin chungquantin merged commit 8170b26 into chungquantin/feat-nfts Nov 22, 2024
13 checks passed
@chungquantin chungquantin deleted the chungquantin/feat-nfts_rebase_clippy branch November 22, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants