Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nfts): mapping with ApprovalsOf in the Allowances storage item #390

Merged
merged 53 commits into from
Nov 26, 2024

Conversation

chungquantin
Copy link
Collaborator

Refactoring the Allowances storage item to map the key as (collection, owner) with ApprovalsOf<T, I> as value. This change will reuse an existing ApprovalOf struct to provide the expiration feature for the collection approvals.

@chungquantin chungquantin changed the title refactor: allowances storage item refactor(nfts): allowances storage item Nov 19, 2024
@chungquantin chungquantin self-assigned this Nov 19, 2024
@chungquantin chungquantin changed the title refactor(nfts): allowances storage item refactor(nfts): mapping with ApprovalsOf in the Allowances storage item Nov 19, 2024
@chungquantin chungquantin changed the base branch from chungquantin/feat-pallet_nonfungibles to chungquantin/feat-nfts November 20, 2024 10:05
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 80.62678% with 68 lines in your changes missing coverage. Please review.

Please upload report for BASE (chungquantin/feat-nfts@e8c5685). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pallets/nfts/src/weights.rs 14.06% 55 Missing ⚠️
pallets/nfts/src/features/approvals.rs 92.85% 3 Missing and 4 partials ⚠️
pallets/nfts/src/benchmarking.rs 85.00% 1 Missing and 2 partials ⚠️
pallets/nfts/src/lib.rs 84.21% 3 Missing ⚠️
@@                    Coverage Diff                    @@
##             chungquantin/feat-nfts     #390   +/-   ##
=========================================================
  Coverage                          ?   70.00%           
=========================================================
  Files                             ?       69           
  Lines                             ?    12388           
  Branches                          ?    12388           
=========================================================
  Hits                              ?     8672           
  Misses                            ?     3452           
  Partials                          ?      264           
Files with missing lines Coverage Δ
pallets/nfts/src/common_functions.rs 71.42% <ø> (ø)
...lets/nfts/src/features/create_delete_collection.rs 84.70% <100.00%> (ø)
pallets/nfts/src/features/transfer.rs 85.51% <100.00%> (ø)
pallets/nfts/src/tests.rs 99.89% <100.00%> (ø)
pallets/nfts/src/types.rs 67.11% <ø> (ø)
pallets/nfts/src/benchmarking.rs 85.71% <85.00%> (ø)
pallets/nfts/src/lib.rs 72.67% <84.21%> (ø)
pallets/nfts/src/features/approvals.rs 92.62% <92.85%> (ø)
pallets/nfts/src/weights.rs 2.10% <14.06%> (ø)

@chungquantin chungquantin changed the base branch from chungquantin/feat-nfts to chungquantin/fix-nfts_destroy_collection November 22, 2024 09:48
@chungquantin chungquantin force-pushed the chungquantin/fix-nfts_destroy_collection branch from 2226f61 to e2a6bf6 Compare November 22, 2024 09:57
@chungquantin chungquantin force-pushed the chungquantin/feat-nfts_allowances branch from acf0d9e to ee73920 Compare November 22, 2024 10:01
Base automatically changed from chungquantin/fix-nfts_destroy_collection to chungquantin/feat-nfts November 22, 2024 10:03
@chungquantin chungquantin force-pushed the chungquantin/feat-nfts_allowances branch from 519a144 to 32ec720 Compare November 26, 2024 07:31
@chungquantin chungquantin merged commit a66ea2a into chungquantin/feat-nfts Nov 26, 2024
12 checks passed
@chungquantin chungquantin deleted the chungquantin/feat-nfts_allowances branch November 26, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants