-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(nfts): mapping with ApprovalsOf
in the Allowances
storage item
#390
Merged
chungquantin
merged 53 commits into
chungquantin/feat-nfts
from
chungquantin/feat-nfts_allowances
Nov 26, 2024
Merged
refactor(nfts): mapping with ApprovalsOf
in the Allowances
storage item
#390
chungquantin
merged 53 commits into
chungquantin/feat-nfts
from
chungquantin/feat-nfts_allowances
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chungquantin
changed the title
refactor: allowances storage item
refactor(nfts): allowances storage item
Nov 19, 2024
12 tasks
chungquantin
changed the title
refactor(nfts): allowances storage item
refactor(nfts): mapping with Nov 19, 2024
ApprovalsOf
in the Allowances
storage item
chungquantin
changed the base branch from
chungquantin/feat-pallet_nonfungibles
to
chungquantin/feat-nfts
November 20, 2024 10:05
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## chungquantin/feat-nfts #390 +/- ##
=========================================================
Coverage ? 70.00%
=========================================================
Files ? 69
Lines ? 12388
Branches ? 12388
=========================================================
Hits ? 8672
Misses ? 3452
Partials ? 264
|
chungquantin
changed the base branch from
chungquantin/feat-nfts
to
chungquantin/fix-nfts_destroy_collection
November 22, 2024 09:48
chungquantin
force-pushed
the
chungquantin/fix-nfts_destroy_collection
branch
from
November 22, 2024 09:57
2226f61
to
e2a6bf6
Compare
chungquantin
force-pushed
the
chungquantin/feat-nfts_allowances
branch
from
November 22, 2024 10:01
acf0d9e
to
ee73920
Compare
Base automatically changed from
chungquantin/fix-nfts_destroy_collection
to
chungquantin/feat-nfts
November 22, 2024 10:03
…fts_allowances' into chungquantin/feat-nfts_allowances
chungquantin
force-pushed
the
chungquantin/feat-nfts_allowances
branch
from
November 26, 2024 07:31
519a144
to
32ec720
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the
Allowances
storage item to map the key as(collection, owner)
withApprovalsOf<T, I>
as value. This change will reuse an existingApprovalOf
struct to provide the expiration feature for the collection approvals.