Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: encoding scheme #271

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

Daanvdplas
Copy link
Collaborator

@Daanvdplas Daanvdplas commented Sep 10, 2024

For tests pallet/api/src/extension.rs see #272

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 91.06145% with 16 lines in your changes missing coverage. Please review.

Project coverage is 45.92%. Comparing base (206757b) to head (0f72c05).

Files with missing lines Patch % Lines
primitives/src/lib.rs 80.55% 7 Missing ⚠️
runtime/devnet/src/config/api/versioning.rs 0.00% 6 Missing ⚠️
pallets/api/src/extension.rs 98.26% 2 Missing ⚠️
extension/src/functions.rs 90.90% 0 Missing and 1 partial ⚠️
@@             Coverage Diff              @@
##           daan/api     #271      +/-   ##
============================================
+ Coverage     42.59%   45.92%   +3.32%     
============================================
  Files            47       47              
  Lines          4139     4279     +140     
  Branches       4139     4279     +140     
============================================
+ Hits           1763     1965     +202     
+ Misses         2319     2252      -67     
- Partials         57       62       +5     
Files with missing lines Coverage Δ
extension/src/matching.rs 100.00% <100.00%> (ø)
extension/src/mock.rs 95.23% <100.00%> (+0.11%) ⬆️
extension/src/functions.rs 92.41% <90.90%> (-0.21%) ⬇️
pallets/api/src/extension.rs 91.82% <98.26%> (+43.49%) ⬆️
runtime/devnet/src/config/api/versioning.rs 60.00% <0.00%> (ø)
primitives/src/lib.rs 91.25% <80.55%> (+91.25%) ⬆️

Copy link
Collaborator

@chungquantin chungquantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

I added a commit to better explain what is going on via the prepender test.

Co-authored-by: Frank Bell <frank@r0gue.io>
@Daanvdplas Daanvdplas merged commit 448cbca into daan/api Sep 12, 2024
10 checks passed
@Daanvdplas Daanvdplas deleted the daan/refactor_encoding_scheme branch September 12, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants