-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: encoding scheme #271
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## daan/api #271 +/- ##
============================================
+ Coverage 42.59% 45.92% +3.32%
============================================
Files 47 47
Lines 4139 4279 +140
Branches 4139 4279 +140
============================================
+ Hits 1763 1965 +202
+ Misses 2319 2252 -67
- Partials 57 62 +5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks.
I added a commit to better explain what is going on via the prepender test.
Co-authored-by: Frank Bell <frank@r0gue.io>
For tests
pallet/api/src/extension.rs
see #272