chore: upgrade to stable2407 #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[sc-1938] |
d7b8260 to
836a78a
Compare
8fd0bc9 to
45b2cf6
Compare
45b2cf6 to
e7abcd9
Compare
Daanvdplas
reviewed
Dec 19, 2024
| parachains-common = { workspace = true, default-features = false } | ||
| polkadot-primitives = { workspace = true, default-features = false } | ||
| parachains-common.workspace = true | ||
| polkadot-primitives.workspace = true | ||
|
|
There was a problem hiding this comment.
Couldn't resist doing a small refactor here making it consistent with the rest of the repo :)
Daanvdplas
reviewed
Dec 19, 2024
| @@ -1,4 +1,5 @@ | |||
| [package] | |||
| authors = [ "R0GUE <go@r0gue.io>" ] | |||
There was a problem hiding this comment.
This was required to build the contracts successfully
Daanvdplas
reviewed
Dec 19, 2024
| @@ -65,7 +67,8 @@ impl pallet_contracts::Config for Runtime { | |||
| type MaxDebugBufferLen = ConstU32<{ 2 * 1024 * 1024 }>; | |||
| type MaxDelegateDependencies = ConstU32<32>; | |||
| type MaxStorageKeyLen = ConstU32<128>; | |||
| type Migrations = (); | |||
| type MaxTransientStorageSize = ConstU32<{ 1024 * 1024 }>; | |||
| type Migrations = (pallet_contracts::migration::v16::Migration<Runtime>,); | |||
There was a problem hiding this comment.
peterwht
approved these changes
Dec 21, 2024
Yes 100%. CI is failing and as I said in the description, the repo doesn't compile :) |
Co-authored-by: chungquantin <56880684+chungquantin@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #234 +/- ##
==========================================
- Coverage 68.41% 68.29% -0.12%
==========================================
Files 70 70
Lines 11838 11861 +23
Branches 11838 11861 +23
==========================================
+ Hits 8099 8101 +2
- Misses 3482 3503 +21
Partials 257 257
|
545a095
into
chore-upgrade-pop-net-to-stable2412/sc-1940
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes in terms of pallet contracts:
type MaxTransientStorageSize = ConstU32<{ 1024 * 1024 }>in the runtimes.IMPORTANT NOTE: this doesn't compile due to westend runtimes. Please compare this PR and once approved we can merge #412 and run the CI.