fix: invalid imported crates & crate visibility #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daanvdplas
reviewed
Aug 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## daan/api #214 +/- ##
=========================================
Coverage 34.08% 34.08%
=========================================
Files 34 34
Lines 3013 3013
Branches 3013 3013
=========================================
Hits 1027 1027
Misses 1954 1954
Partials 32 32 |
|
Thank you Tin! |
Daanvdplas
pushed a commit
that referenced
this pull request
Aug 19, 2024
Daanvdplas
pushed a commit
that referenced
this pull request
Aug 19, 2024
chungquantin
added a commit
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix existing error in the
daan/apibranch occurs in the contract & contract integration test.