Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing space in XML header #7

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Conversation

renkun-ken
Copy link

XML validator complains the missing space in the XML header produced by xml_parse_data.

<?xml version="1.0" encoding="UTF-8"standalone="yes" ?>

should be

<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>

@codecov-io
Copy link

codecov-io commented Oct 17, 2019

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #7   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          56     56           
=====================================
  Hits           56     56
Impacted Files Coverage Δ
R/package.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b03136...4dbbfac. Read the comment docs.

@gaborcsardi gaborcsardi merged commit e05dd2a into r-lib:master Oct 17, 2019
@gaborcsardi
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants