Adjust test + add snapshot

r-lib · Dec 1, 2023 · 697cb47 · 697cb47
1 parent a85effe
commit 697cb47
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/tests/testthat/_snaps/xml_parse.md b/tests/testthat/_snaps/xml_parse.md
@@ -2,6 +2,16 @@
 
     `x` must be a single string, not an empty character vector.
 
+# parse_options errors when given an invalid option
+
+    Code
+      read_html(test_path("lego.html.bz2"), options = "INVALID")
+    Condition
+      Error in `read_html()`:
+      x `options` "INVALID" is not a valid option.
+      i Valid options are one of "RECOVER", "NOENT", "DTDLOAD", "DTDATTR", "DTDVALID", "NOERROR", "NOWARNING", "PEDANTIC", "NOBLANKS", "SAX1", "XINCLUDE", "NONET", "NODICT", "NSCLEAN", "NOCDATA", "NOXINCNODE", "COMPACT", "OLD10", ..., "IGNORE_ENC", or "BIG_LINES".
+      i See read_html (`?xml2::read_html()`) for all options.
+
 # read_xml and read_html fail with > 1 input
 
     `x` must be a single string, not a character vector.

diff --git a/tests/testthat/test-xml_parse.R b/tests/testthat/test-xml_parse.R
@@ -26,12 +26,11 @@ test_that("read_html correctly parses malformed document", {
 test_that("parse_options errors when given an invalid option", {
   expect_error(
     parse_options("INVALID", xml_parse_options()),
-    "`options` 'INVALID' is not a valid option"
+    '`options` "INVALID" is not a valid option'
   )
 
-  expect_error(
-    read_html(test_path("lego.html.bz2"), options = "INVALID"),
-    "`options` 'INVALID' is not a valid option"
+  expect_snapshot(error = TRUE,
+    read_html(test_path("lego.html.bz2"), options = "INVALID")
   )
 
   # Empty inputs returned as 0