Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't import glue #195

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Don't import glue #195

merged 1 commit into from
Aug 21, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented Aug 6, 2024

@jennybc
Copy link
Member

jennybc commented Aug 16, 2024

What are your thoughts on the various changes that will make glue pass R CMD check again?

  1. You merge this PR.
  2. I register compare_proxy.glue the "old" way in glue.
  3. We hope for a change in base R.

Clearly we have a lot more control over 1. and 2.

@hadley hadley merged commit 5bef1cf into main Aug 21, 2024
13 checks passed
@hadley hadley deleted the dont-import-glue branch August 21, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants