-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mock_output_sequence()
similar to {mockery}'s multiple return values
#2061
Changes from 3 commits
b321b22
d2e4869
6f61047
48b44af
f20a031
328e549
5982f64
b95749a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
#' Mock a sequence of output from a function | ||
#' | ||
#' Specify multiple return values for mocking | ||
#' | ||
#' @param values vector of values to return in sequence. | ||
#' @param recycle whether to recycle. If `TRUE`, once all values have been returned, | ||
#' they will be returned again in sequence. | ||
#' | ||
#' @return A function that you can use within `local_mocked_bindings()` and | ||
#' `with_mocked_bindings()` | ||
#' @export | ||
#' | ||
#' @examples | ||
#' # inside local_mocked_bindings() | ||
#' \dontrun{ | ||
#' local_mocked_bindings(readline = mock_output_sequence(c("3", "This is a note", "n"))) | ||
#' } | ||
#' # for understanding | ||
#' mocked_sequence <- mock_output_sequence(c("3", "This is a note", "n")) | ||
#' mocked_sequence() | ||
#' mocked_sequence() | ||
#' mocked_sequence() | ||
#' try(mocked_sequence()) | ||
#' recycled_mocked_sequence <- mock_output_sequence( | ||
#' c("3", "This is a note", "n"), | ||
#' recycle = TRUE | ||
#' ) | ||
#' recycled_mocked_sequence() | ||
#' recycled_mocked_sequence() | ||
#' recycled_mocked_sequence() | ||
#' recycled_mocked_sequence() | ||
#' @family mocking | ||
mock_output_sequence <- function(values, recycle = FALSE) { | ||
force(values) | ||
i <- 1 | ||
function(...) { | ||
if (i > length(values) && !recycle) { | ||
cli::cli_abort(c( | ||
"Can't find value for {i}th iteration.", | ||
i = "{.arg values} has only {length(values)} values.", | ||
i = "You can set {.arg recycle} to {.code TRUE}." | ||
)) | ||
} | ||
value <- rep_len(values, length.out = i)[[i]] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It'd be a little more efficient to do this with modular arithmetic, something like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Aaaah I had not found this elegant solution. Code now refactored! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (I had been using the modulo operator with if and else... 🤪 ) |
||
i <<- i + 1 | ||
value | ||
} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
# mock_output_sequence() works | ||
|
||
Code | ||
mocked_sequence() | ||
Condition | ||
Error in `mocked_sequence()`: | ||
! Can't find value for 4th iteration. | ||
i `values` has only 3 values. | ||
i You can set `recycle` to `TRUE`. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
test_that("mock_output_sequence() works", { | ||
mocked_sequence <- mock_output_sequence(c("3", "This is a note", "n")) | ||
expect_equal(mocked_sequence(), "3") | ||
expect_equal(mocked_sequence(), "This is a note") | ||
expect_equal(mocked_sequence(), "n") | ||
expect_snapshot(mocked_sequence(), error = TRUE) | ||
}) | ||
|
||
test_that("mock_output_sequence()'s recycling works", { | ||
mocked_sequence <- mock_output_sequence( | ||
c("3", "This is a note", "n"), | ||
recycle = TRUE | ||
) | ||
expect_equal(mocked_sequence(), "3") | ||
expect_equal(mocked_sequence(), "This is a note") | ||
expect_equal(mocked_sequence(), "n") | ||
expect_equal(mocked_sequence(), "3") | ||
}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use
...
instead ofvalues
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be sure I understand: do you mean that instead of writing
mock_output_sequence(c("blop", "bla"))
the user would writemock_output_sequence("blop", "bla")
?And using rlang's "Dynamic dots features"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes and yes 😄