Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement zap_srcref() in C #1513

Closed
hadley opened this issue Oct 18, 2022 · 2 comments · Fixed by #1567
Closed

Reimplement zap_srcref() in C #1513

hadley opened this issue Oct 18, 2022 · 2 comments · Fixed by #1567

Comments

@hadley
Copy link
Member

hadley commented Oct 18, 2022

It's causing a bottleneck in large shiny apps.
@hadley
Copy link
Member Author

hadley commented Jan 17, 2023

Would be great to prioritise this in the next minor release.

@wch
Copy link
Member

wch commented Jan 17, 2023

Just to add some data, here's a profvis flame graph showing how much time is spent in zap_srcref when a user connects to a large Shiny app. In this app, it's 640ms, and each user has to pay this price.

image (18)

lionel- added a commit that referenced this issue Feb 16, 2023
@lionel-
Rewrite zap_srcref() in C
a25e85b 
Closes #1513
@lionel- lionel- mentioned this issue Feb 16, 2023
Merged
lionel- added a commit that referenced this issue Feb 17, 2023
@lionel-
Rewrite zap_srcref() in C (#1567)
3afd553 
Closes #1513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite zap_srcref() in C r-lib/rlang
2 participants
@hadley @wch