Don't tweak src URL of img links, if absolute #1955
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vroom sources
taylor.gif
from a raw GitHub link in README /index.html
. The gif used to live ingh-pages
, but that's not compatible withclean = TRUE
indeploy_to_branch()
, i.e. it keeps going missing.I tried relocating the gif to
man/figures
andvignettes
, but the link remained broken in the rendered site. I then realized that the link was being tweaked by pkgdown to a nonexistent path, when transformingREADME.md
intoindex.html
.Based on the comment above
tweak_img_src()
(# Fix relative image links
), I'm pretty sure this PR is compatible with the original intent.