Enable deploy_site_github() to handle GH enterprise instances #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 17, 2019 13:22
|
Looks fine to me, apart from the style problems. |
|
@jayhesselberth @hadley Thanks for the review! The style issues raised have been fixed. |
|
Thanks! |
This was referenced Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deploy_site_github()does not currently support enterprise github for deployment and defaults to github.com. This is hardcoded in thegithub_clone()function.The proposal in this PR is to add a new argument
hostthat would allow enterprise users to specify the URL of their github instance when deploying with Travis. I can confirm that this approach works for my org's internal github.Happy to provide any additional information.