-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
News sections not rendered if version is in parentheses #980
Comments
This regex fails to capture parenthetical versions: Line 149 in 59cc923
|
Notably this header renders fine:
but makes for a long section title. |
The usethis behavior could be updated to add the dev version before the parentheses. |
Same thing also happens if you put a v in front of the version, pkgdown v1.3.0.9000Would cause the news to be dropped on the site. The page is there but no content. |
I think we should accommodate these formats:
|
Included a decent amount of refactoring, first to make the regular expression more readable, and then to make news_version return something that was easier to test. Fixes #980
Included a decent amount of refactoring, first to make the regular expression more readable, and then to make news_version return something that was easier to test. Fixes #980
Rendering NEWS.md with a version in paretheses causes it to be dropped from the rendered page.
If a section begins with this header, it is not present in the rendered page:
# pkgdown (development version)
This renders fine:
# pkgdown 1.3.0.9000
This explains why the development version section is not present on the dev docs
The text was updated successfully, but these errors were encountered: