Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar icons left of search #2320

Closed
john-ioannides opened this issue Jun 9, 2023 · 2 comments · Fixed by #2449
Closed

Navbar icons left of search #2320

john-ioannides opened this issue Jun 9, 2023 · 2 comments · Fixed by #2449
Labels
feature a feature request or enhancement navbar 🗺️
Milestone

Comments

@john-ioannides
Copy link

I have this code indicating that the back icon should be placed left of the search bar, but instead it's placed on the right.

navbar:
  structure:
    right: [goback, search, gogs]
  components:
    goback:
      icon: fa-arrow-left
      href: /..
      aria-label: RZPackageLibrary
  gogs:
        icon: fa-code

image

@hadley hadley added bug an unexpected problem or unintended behavior navbar 🗺️ labels Oct 30, 2023
@hadley
Copy link
Member

hadley commented Apr 12, 2024

Looks like you can't actually control the placement of search this way; it's always included between the left and the right components. Fixing this is going to be fiddly, it doesn't seem to be something too many people have hit, and there's a workaround, so I think the best bet here is just to make a note in the docs.

@hadley hadley added documentation and removed bug an unexpected problem or unintended behavior labels Apr 12, 2024
@hadley hadley added this to the 2.1.0 milestone Apr 12, 2024
@hadley
Copy link
Member

hadley commented Apr 16, 2024

Hmmm, maybe it would be better to just fix this.

hadley added a commit that referenced this issue Apr 16, 2024
Fixes #2320

I tested the visual appearance manually in a few places, and it looks good to me. @maelle it'd be useful if you could kick the tires on it a bit too.

While working on this code, I realised that we'd been incorrectly labelling the search box as "toggle navigation" to screen readers 🤦 I've fixed that in this PR too.
@hadley hadley added feature a feature request or enhancement and removed documentation labels Apr 17, 2024
hadley added a commit that referenced this issue Apr 19, 2024
Fixes #2320

I tested the visual appearance manually in a few places, and it looks good to me. @maelle it'd be useful if you could kick the tires on it a bit too.

While working on this code, I realised that we'd been incorrectly labelling the search box as "toggle navigation" to screen readers 🤦 I've fixed that in this PR too.
SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this issue Jun 1, 2024
Fixes r-lib#2320

I tested the visual appearance manually in a few places, and it looks good to me. @maelle it'd be useful if you could kick the tires on it a bit too.

While working on this code, I realised that we'd been incorrectly labelling the search box as "toggle navigation" to screen readers 🤦 I've fixed that in this PR too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement navbar 🗺️
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants