-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navbar icons left of search #2320
Comments
Looks like you can't actually control the placement of search this way; it's always included between the left and the right components. Fixing this is going to be fiddly, it doesn't seem to be something too many people have hit, and there's a workaround, so I think the best bet here is just to make a note in the docs. |
hadley
added
documentation
and removed
bug
an unexpected problem or unintended behavior
labels
Apr 12, 2024
Hmmm, maybe it would be better to just fix this. |
hadley
added a commit
that referenced
this issue
Apr 16, 2024
Fixes #2320 I tested the visual appearance manually in a few places, and it looks good to me. @maelle it'd be useful if you could kick the tires on it a bit too. While working on this code, I realised that we'd been incorrectly labelling the search box as "toggle navigation" to screen readers 🤦 I've fixed that in this PR too.
hadley
added a commit
that referenced
this issue
Apr 19, 2024
Fixes #2320 I tested the visual appearance manually in a few places, and it looks good to me. @maelle it'd be useful if you could kick the tires on it a bit too. While working on this code, I realised that we'd been incorrectly labelling the search box as "toggle navigation" to screen readers 🤦 I've fixed that in this PR too.
SebKrantz
pushed a commit
to SebKrantz/pkgdown
that referenced
this issue
Jun 1, 2024
Fixes r-lib#2320 I tested the visual appearance manually in a few places, and it looks good to me. @maelle it'd be useful if you could kick the tires on it a bit too. While working on this code, I realised that we'd been incorrectly labelling the search box as "toggle navigation" to screen readers 🤦 I've fixed that in this PR too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have this code indicating that the back icon should be placed left of the search bar, but instead it's placed on the right.
The text was updated successfully, but these errors were encountered: