Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links from dev site to regular site #1262

Closed
hadley opened this issue Mar 21, 2020 · 1 comment · Fixed by #1264
Closed

Links from dev site to regular site #1262

hadley opened this issue Mar 21, 2020 · 1 comment · Fixed by #1264
Labels
bug an unexpected problem or unintended behavior linking 📎
Milestone
1.5.0

Comments

@hadley
Copy link
Member

hadley commented Mar 21, 2020

https://pkgdown.r-lib.org/dev/reference/templates.html

I think something is wrong with namespaced links to the current package.
@hadley hadley added bug an unexpected problem or unintended behavior linking 📎 labels Mar 21, 2020
@hadley hadley added this to the 1.5.0 milestone Mar 21, 2020
@hadley
Copy link
Member Author

hadley commented Mar 21, 2020

The problem is tweak_pre_node() which unconditionally calls href_topic_remote()

@hadley hadley mentioned this issue Mar 21, 2020
Closed
hadley added a commit that referenced this issue Mar 21, 2020
@hadley
Check package name before making a remote link
1535cb7 
I'm not sure how I missed this before, but this has clearly been a problem for a long time.

Fixes #1262
@hadley hadley mentioned this issue Mar 21, 2020
Merged
hadley added a commit that referenced this issue Mar 22, 2020
@hadley
Check package name before making a remote link
430548b 
I'm not sure how I missed this before, but this has clearly been a problem for a long time.

Fixes #1262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior linking 📎
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

Check package name before making a remote link r-lib/pkgdown
1 participant
@hadley