Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GitLab for page source printing #1045

Closed
msberends opened this issue May 28, 2019 · 4 comments · Fixed by #1253
Closed

Support GitLab for page source printing #1045

msberends opened this issue May 28, 2019 · 4 comments · Fixed by #1253
Labels
feature a feature request or enhancement linking 📎

Comments

@msberends
Copy link
Contributor

When the URL field in the DESCRIPTION file contains github.com, the page source is printed on all reference pages:

URL: https://msberends.gitlab.io/AMR, https://github.com/msberends/AMR

image

But when the URL field contains gitlab.com, (which it actually does), the page source is not printed:

URL: https://msberends.gitlab.io/AMR, https://gitlab.com/msberends/AMR

image

The suffix /blob/master/ also works for GitLab - all full URLs are exactly the same as GitHub, aside from the domain. Any plan to support? Would be great!
And then perhaps also an option in _pkgdown.yml to turn this on (default) and off?
@hadley hadley added feature a feature request or enhancement linking 📎 labels Aug 26, 2019
floriandeboissieu added a commit to floriandeboissieu/pkgdown that referenced this issue Jan 15, 2020
@floriandeboissieu
linking to other git than github
3897c85 
A proposition to link to other git plateforms than github, e.g. gitlab.com or any gitlab server, as asked in issue r-lib#1045
I did not change add_github_links accoringly as I do not see clearly how neither what it is for...
@floriandeboissieu floriandeboissieu mentioned this issue Jan 15, 2020
Closed
@hadley hadley mentioned this issue Mar 11, 2020
Closed
@hadley
Copy link
Member

hadley commented Mar 11, 2020

Duplicate of new #1238

@hadley hadley closed this as completed Mar 11, 2020
@hadley hadley mentioned this issue Mar 16, 2020
Merged
@chuxinyuan
Copy link

chuxinyuan commented Jun 24, 2020 •
edited
Loading

When my source is GitLab, I found that the icon on the generated web page was GitHub, but the connection was normal and I needed to make some adjustments in docs/index.html.

<span class="fab fa fab fa-gitlab fa-lg"></span>

@hadley
Copy link
Member

hadley commented Jun 24, 2020

@chuxinyuan can you please file a new issue? Commenting on a closed issue is not generally a good way to get results.

@chuxinyuan
Copy link

@hadley Sorry, I will file a new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement linking 📎
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support alternate hosts r-lib/pkgdown
3 participants
@hadley @chuxinyuan @msberends