Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/gha workflow lint #689

Merged
merged 5 commits into from
Dec 6, 2020
Merged

Bug/gha workflow lint #689

merged 5 commits into from
Dec 6, 2020
+6 −2

Conversation

dragosmg
Copy link
Collaborator

@dragosmg dragosmg commented Dec 6, 2020

closes #688

@dragosmg
Copy link
Collaborator Author

dragosmg commented Dec 6, 2020

@AshesITR I've made the changes suggested in #688, but this has now resulted in quite a few lints for the lint / .lintr workflow - https://github.com/jimhester/lintr/actions/runs/404278311.

@dragosmg dragosmg marked this pull request as ready for review December 6, 2020 17:55
@AshesITR
Copy link
Collaborator

AshesITR commented Dec 6, 2020

Thanks for notifying. #687 will fix all of those (> 200) lints.
They were caused by #673 (increased cyclocomp of lint() to 30) and #669 (tests no longer ignored).

AshesITR
AshesITR approved these changes Dec 6, 2020
View reviewed changes
Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@AshesITR AshesITR merged commit 0830478 into r-lib:master Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshesITR AshesITR AshesITR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lint workflows
2 participants
@dragosmg @AshesITR