Check on multiple r releases #402
Merged
+32
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used `use_tidy_ci()` to expand the R-releases used during CI tests - add configs for codecov - bump R dependency to R >= 3.2 (since 3.2 is the earliest release used in CI; also dependency httr/knitr require R >= 3.2) - `use_tidy_ci` modified `cran-comments.md`; I changed the file so that R 3.1 wasnt mentioned in the travis section. But, I dont really know what is supposed to go in this file.
|
(Sorry I thought I'd PR'd against my own fork; I'll remove the failing test in a bit) |
A test that should always fail was added to the previous commit on purpose (expect_true(FALSE)) to check that CI would fail at least once for all builds. R CMD check did fail at the injected test for each build. Hence, the test was removed.
|
Following discussion in #384 (now closed; #384 (comment)) a few different releases of R were added to the travis config; lintr is now built against R-3.[2|3|4], and the old / current / devel-releases of R. A failing test was added to the initial commit to ensure that lintr builds but fails |
jimhester
approved these changes
Aug 29, 2019
|
Great work, this package is now better thanks to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add matrix of travis R releases (3.2 -> devel)
Note that I've added a failing test just to check that CI fails for all builds before pushing to lintr master