Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml2lang retains some whitespace #2132

Merged
merged 3 commits into from
Sep 11, 2023
Merged

xml2lang retains some whitespace #2132

merged 3 commits into from
Sep 11, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Closes #2131

The key for a reprex is that removing whitespace causes a parse failure, so if (A) x else y won't work because if (A) xelsey is actually fine, and apparently if (A) "" else "" is also fine. if (A) "" else y is the shortest I could see that causes the parse failure when is stripped.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Merging #2132 (ce59503) into main (9bd015d) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head ce59503 differs from pull request most recent head 2438526. Consider uploading reports for the commit 2438526 to get more accurate results

@@           Coverage Diff           @@
##             main    #2132   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         112      112           
  Lines        5116     5125    +9     
=======================================
+ Hits         5098     5107    +9     
  Misses         18       18           
Files Changed Coverage Δ
R/lint.R 98.88% <100.00%> (+0.02%) ⬆️
R/utils.R 99.05% <100.00%> (ø)

NEWS.md Show resolved Hide resolved
@AshesITR AshesITR merged commit a59c6c0 into main Sep 11, 2023
@AshesITR AshesITR deleted the sprintf-bug branch September 11, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sprintf_linter() fails on complex input
3 participants