Catch consecutive calls to assert_that in renamed consecutive_asserion_linter

[MichaelChirico]

Closes #1604

[codecov-commenter]

Codecov Report

Merging #1940 (47f0585) into main (ddc1b71) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 47f0585 differs from pull request most recent head 5a302fe. Consider uploading reports for the commit 5a302fe to get more accurate results

@@           Coverage Diff           @@
##             main    #1940   +/-   ##
=======================================
  Coverage   98.94%   98.95%           
=======================================
  Files         113      113           
  Lines        4939     4953   +14     
=======================================
+ Hits         4887     4901   +14     
  Misses         52       52           

Impacted Files	Coverage Δ
R/utils.R	98.29% <ø> (ø)
R/consecutive_assertion_linter.R	100.00% <100.00%> (ø)
R/lintr-deprecated.R	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[MichaelChirico]

NB: this comment intentionally removed as the logic now lints on cases like:

assert_that(x)
assertthat::assert_that(y)

Technically it would also lint on

SomePkg::stopifnot(x)
base::stopifnot(y)

But that seems unlikely in practice. We could extend the logic to something like "lint if the namespaces are equal or both absent, or if only present once, but not if both present and not equal" but that seems like overkill.

[IndrajeetPatil]

LGTM. Thanks!