Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect functional lambdas in object_usage_linter #1934

Merged
merged 2 commits into from
Apr 2, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Closes #1933

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2023

Codecov Report

Merging #1934 (0424901) into main (01500d8) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 0424901 differs from pull request most recent head 3caa643. Consider uploading reports for the commit 3caa643 to get more accurate results

@@           Coverage Diff           @@
##             main    #1934   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files         113      113           
  Lines        4939     4939           
=======================================
  Hits         4883     4883           
  Misses         56       56           
Impacted Files Coverage Δ
R/object_usage_linter.R 99.39% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MichaelChirico
Copy link
Collaborator Author

Test failure looks spurious / caused by upstream

@MichaelChirico MichaelChirico added this to the 3.1.0 milestone Mar 29, 2023
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@IndrajeetPatil IndrajeetPatil merged commit 2997038 into main Apr 2, 2023
@IndrajeetPatil IndrajeetPatil deleted the object-usage-lambda branch April 2, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

object_usage_linter() misses functions defined with \(x) lambda
3 participants