Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let MBCS warning fall through the first time it's encountered #1923

Merged
merged 5 commits into from
Feb 28, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Closes #1920. Not an ideal solution but I'd rather just un-break our CI for now.

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023

Codecov Report

Merging #1923 (d7ffa33) into main (27890d5) will decrease coverage by 0.02%.
The diff coverage is 83.33%.

❗ Current head d7ffa33 differs from pull request most recent head 9bc44b2. Consider uploading reports for the commit 9bc44b2 to get more accurate results

@@            Coverage Diff             @@
##             main    #1923      +/-   ##
==========================================
- Coverage   98.86%   98.84%   -0.02%     
==========================================
  Files         112      112              
  Lines        4852     4857       +5     
==========================================
+ Hits         4797     4801       +4     
- Misses         55       56       +1     
Impacted Files Coverage Δ
R/extract.R 98.52% <83.33%> (-1.48%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Yeah, I agree that we should resolve the CI/CD failure ASAP, and this is good enough to get there.

@IndrajeetPatil IndrajeetPatil merged commit 7e6cfcd into main Feb 28, 2023
@IndrajeetPatil IndrajeetPatil deleted the MichaelChirico-patch-5 branch February 28, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strict test (warnings=errors) failing because of encoding issue
3 participants