Separate out tests for allowed assignments with braces #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `implicit_assignment_linter()`
IndrajeetPatil
commented
Dec 21, 2022
| test_that("implicit_assignment_linter makes exceptions for functions that capture side-effects", { | ||
| linter <- implicit_assignment_linter() | ||
| test_that("implicit_assignment_linter skips allowed usages with braces", { | ||
| linter <- implicit_assignment_linter(except = character(0L)) |
There was a problem hiding this comment.
Note that no exceptions are included here.
Codecov Report
@@ Coverage Diff @@
## main #1872 +/- ##
=======================================
Coverage 98.86% 98.86%
=======================================
Files 112 112
Lines 4841 4841
=======================================
Hits 4786 4786
Misses 55 55 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| expect_lint("quote(a <- 1L)", NULL, linter) | ||
| expect_lint("bquote(a <- 1L)", NULL, linter) | ||
| expect_lint("expression(a <- 1L)", NULL, linter) | ||
| expect_lint("output <- capture.output({ x <- f() })", NULL, linter) |
There was a problem hiding this comment.
looks like these are all side-effect functions... my recollection (CMIIW) was we wanted to allow <- within braces no matter the parent function.
If that's the case, could you make some of these tests use a generic function like foo({ a <- 1L })?
It may also be preferable to keep the code aligned to the rest of the default linters, which means using
foo({
a <- 1L
})because of brace_linter().
MichaelChirico
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
implicit_assignment_linter()