Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on empty character vector args in undesirable linters #1870

Merged
merged 3 commits into from
Dec 23, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

Closes #1867

@IndrajeetPatil
Copy link
Collaborator Author

Builds are failing on R 3.4 because of {purrr}. No idea why.

Failed to build purrr 1.0.0
  Error: 
  ! error in pak subprocess
  Caused by error in `stop_task_build(state, worker)`:
  ! Failed to build source package 'purrr'

@codecov-commenter
Copy link

Codecov Report

Merging #1870 (bbfb366) into main (8c05027) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1870   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files         112      112           
  Lines        4839     4841    +2     
=======================================
+ Hits         4784     4786    +2     
  Misses         55       55           
Impacted Files Coverage Δ
R/undesirable_function_linter.R 100.00% <100.00%> (ø)
R/undesirable_operator_linter.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different behaviour of undesirable linters with empty character vectors
3 participants