Deprecate unnecessary_concatenation_linter()
#1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In favour of `unnecessary_concatenation_linter()` Closes #1797
Codecov Report
@@ Coverage Diff @@
## main #1862 +/- ##
=======================================
Coverage 98.85% 98.85%
=======================================
Files 112 112
Lines 4811 4823 +12
=======================================
+ Hits 4756 4768 +12
Misses 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@MichaelChirico How can I add tests for new validation tests I have added. I thought the following would work, but it produces an error: test_that("invalid allow_single_expression argument produce informative error messages", {
expect_error(
expect_lint("c()", NULL, unnecessary_concatenation_linter(allow_single_expression = 1)),
"is.logical(allow_single_expression) is not TRUE"
)
expect_error(
expect_lint("c()", NULL, unnecessary_concatenation_linter(allow_single_expression = c(TRUE, FALSE))),
"length(allow_single_expression) == 1L is not TRUE"
)
}) |
|
use rex() right? |
MichaelChirico
approved these changes
Dec 18, 2022
camden-bock
added a commit
to camden-bock/report
that referenced
this pull request
May 7, 2023
rempsyc
added a commit
to easystats/report
that referenced
this pull request
May 20, 2023
* Update report.data.frame.R ensure that the first group is reported. * styler * Update test-report.data.frame.R fix to reflect the expected behavior with iris grouped on species * Update .lintr see r-lib/lintr#1862 * Update report.data.frame.R address `commented code should be removed` from lintr. * styler update * Update DESCRIPTION Add Camden Bock to Contributors * Update DESCRIPTION fix typo --------- Co-authored-by: Rémi Thériault <13123390+rempsyc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In favour of
unnecessary_concatenation_linter()Closes #1797