Improve error message in namespace_linter()
#1844
Conversation
Specifically, mention where to create issue if the linter fails.
Codecov Report
@@ Coverage Diff @@
## main #1844 +/- ##
=======================================
Coverage 98.85% 98.85%
=======================================
Files 112 112
Lines 4816 4818 +2
=======================================
+ Hits 4761 4763 +2
Misses 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
R/namespace_linter.R
Outdated
| if (any(failed_namespace)) { | ||
| stop("Failed to retrieve namespaces for one or more of the packages. Please report this issue.") # nocov | ||
| stop( | ||
| "Failed to retrieve namespaces for one or more of the packages. ", |
There was a problem hiding this comment.
Let's improve this message too while we're at it -- "the packages" is a bit vague, what packages?
We could either describe it generally "one or more of the packages used with :: or :::", or more specifically by actually naming the packages.
There was a problem hiding this comment.
For now, I have just included the generic message.
I have created a new issue (#1855) to remember to improve the message by including problematic package names, since it isn't as trivial as I thought, and don't want to expand the scope of this PR beyond what I originally had in mind.
Specifically, mention where to create issue if the linter fails.