Add S3 group generics to .base_s3_generics, include exported S3 generics in generic list
#1842
Conversation
67bd22d to
79848fb
Compare
.base_s3_generics.base_s3_generics, include exported S3 generics in generic list
| @@ -1,5 +1,5 @@ | |||
| # Parse namespace files and return imports exports, methods | |||
| namespace_imports <- function(path = find_package()) { | |||
| namespace_imports <- function(path = find_package(".")) { | |||
There was a problem hiding this comment.
The previous default was an error.
| @@ -35,7 +35,7 @@ safe_get_exports <- function(ns) { | |||
| } | |||
|
|
|||
| empty_namespace_data <- function() { | |||
| data.frame(pkg = character(), ns = character(), stringsAsFactors = FALSE) | |||
| data.frame(pkg = character(), fun = character(), stringsAsFactors = FALSE) | |||
There was a problem hiding this comment.
All other code paths return a data frame with column names pkg and fun.
| #' @export | ||
| #' Defined S3 generic in R/eat_me.R | ||
| #' Tests #1808 | ||
| eat_me.liiiiiiiiiiiiiiiiiiiiiiiiiiist <- function(x, ...) { |
There was a problem hiding this comment.
Class name has length 30, so this provokes object_length_linter().
| S3method("names<-",my_custom_class) | ||
| S3method(drink_me,data.frame) | ||
| S3method(drink_me,default) | ||
| S3method(drink_me,list) | ||
| S3method(eat_me,liiiiiiiiiiiiiiiiiiiiiiiiiiist) | ||
| S3method(head,my_s3_object) |
There was a problem hiding this comment.
These are necessary for fixing #1808
Codecov Report
@@ Coverage Diff @@
## main #1842 +/- ##
=======================================
Coverage 98.86% 98.86%
=======================================
Files 112 112
Lines 4825 4838 +13
=======================================
+ Hits 4770 4783 +13
Misses 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
The builds still seem to be failing older R versions. |
|
I'm looking into it, but it's slow for me to debug on old r versions. |
|
🤦🏼♂️ the old |
fixes #1841 and #1808