Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow except = NULL to remove all exceptions in implicit_assignment_linter() #1840

Merged
merged 4 commits into from
Dec 16, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

Setting this argument to NULL feels like a more natural way to go about removing exceptions than except = character().

@IndrajeetPatil IndrajeetPatil added the feature a feature request or enhancement label Dec 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2022

Codecov Report

Merging #1840 (042f6a0) into main (f451f5d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1840   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files         112      112           
  Lines        4817     4817           
=======================================
  Hits         4762     4762           
  Misses         55       55           
Impacted Files Coverage Δ
R/implicit_assignment_linter.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AshesITR AshesITR merged commit 73f744a into main Dec 16, 2022
@IndrajeetPatil IndrajeetPatil deleted the allow_null_implicit_assign branch December 16, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants