-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use braces in tryCatch()
calls
#1839
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1839 +/- ##
=======================================
Coverage 98.85% 98.85%
=======================================
Files 112 112
Lines 4814 4815 +1
=======================================
+ Hits 4759 4760 +1
Misses 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
R/get_source_expressions.R
Outdated
# This object should be named `e` because, if invalid characters are present, | ||
# the error needs to be assigned in the parent frame, where it is named `e`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this reason, the content can't be assigned to parsed_content
or some other, more informative name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't the parent's name given by the first argument to assign()?
so assign("e", parsed_content, ...) works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes, true that.
Sorry, I was doing search and replace, which changed both e
and "e"
, and that's why it wasn't working.
I have made the necessary change now and the object is called parsed_content
.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Inspired by discussion in #1817.