Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement implicit_assignment_linter() #1814

Merged
merged 18 commits into from
Dec 8, 2022
Merged

Implement implicit_assignment_linter() #1814

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
2d4d35c
Implement `implicit_assignment_linter()`
IndrajeetPatil Dec 8, 2022
a438880
remove new lints
IndrajeetPatil Dec 8, 2022
fc6c02e
exception for functions that capture side-effect
IndrajeetPatil Dec 8, 2022
e989ae4
link to style guide
IndrajeetPatil Dec 8, 2022
33cfc45
description
IndrajeetPatil Dec 8, 2022
d3bc0e8
get rid of false positives for control flows
IndrajeetPatil Dec 8, 2022
316771d
add failing test
IndrajeetPatil Dec 8, 2022
c0158a3
Update XPath
IndrajeetPatil Dec 8, 2022
e594df0
expand on the exceptions (to be revised)
IndrajeetPatil Dec 8, 2022
b8d9225
more tests
IndrajeetPatil Dec 8, 2022
e10961d
order by package
IndrajeetPatil Dec 8, 2022
be81d0c
fix test
IndrajeetPatil Dec 8, 2022
804d361
more rlang
IndrajeetPatil Dec 8, 2022
1eee93e
Merge branch 'main' into 1777_implicit_assignment_linter
IndrajeetPatil Dec 8, 2022
8355896
tests for lambdas
IndrajeetPatil Dec 8, 2022
aa57f79
reformat vector
IndrajeetPatil Dec 8, 2022
2cc6460
also cover `for` loop
IndrajeetPatil Dec 8, 2022
3469d9d
remove lint
IndrajeetPatil Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
description
  • Loading branch information
@IndrajeetPatil
IndrajeetPatil committed Dec 8, 2022
commit 33cfc45e5a90035932028563ba1f63c1ac478e93
3 changes: 3 additions & 0 deletions R/implicit_assignment_linter.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#' Avoid implicit assignment in function calls
#'
#' Assigning inside function calls makes the code difficult to read, and should
#' be avoided, except for functions that capture side-effects (e.g. [capture.output()]).
#'
#' @examples
#' # will produce lints
#' lint(
Expand Down
3 changes: 2 additions & 1 deletion man/implicit_assignment_linter.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.