Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use public interface to test internal functions: Part-4 #1774

Merged
merged 10 commits into from
Nov 26, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

Part of #1692

@IndrajeetPatil IndrajeetPatil added the internals Issues related to inner workings of lintr, i.e., not user-visible label Nov 21, 2022
Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the new tests don't guarantee the .lintr config is found at the expected place, the old ones test for that as well.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

Merging #1774 (8bb02b8) into main (4aed6d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1774   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files         109      109           
  Lines        4653     4653           
=======================================
  Hits         4601     4601           
  Misses         52       52           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@IndrajeetPatil
Copy link
Collaborator Author

Currently the new tests don't guarantee the .lintr config is found at the expected place, the old ones test for that as well.

Thanks. Added tests to check this as well.

tests/testthat/test-use_lintr.R Outdated Show resolved Hide resolved
tests/testthat/test-use_lintr.R Outdated Show resolved Hide resolved
@IndrajeetPatil IndrajeetPatil merged commit 8e7bfc9 into main Nov 26, 2022
@IndrajeetPatil IndrajeetPatil deleted the 1692_part_4 branch November 26, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Issues related to inner workings of lintr, i.e., not user-visible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants