Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove undesirable_operator_linter() from .lintr_new #1767

Merged
merged 4 commits into from
Nov 9, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

Closes #1766

Add it back once #1692 is resolved

@IndrajeetPatil IndrajeetPatil changed the title Remove undesirable_operator_linter from .lintr_new Remove undesirable_operator_linter() from .lintr_new Nov 9, 2022
@IndrajeetPatil IndrajeetPatil marked this pull request as ready for review November 9, 2022 19:42
@AshesITR
Copy link
Collaborator

AshesITR commented Nov 9, 2022

There are a few more:

Targets
    Occurrences of 'nolint: undesirable_operator' in Project
Found Occurrences in Project  (9 usages found)
    Usage in comments  (9 usages found)
        lintr  (9 usages found)
            R  (9 usages found)
                expect_lint.R  (1 usage found)
                    87 itr <<- itr + 1L # nolint: undesirable_operator.
                get_source_expressions.R  (1 usage found)
                    591 cum_offset <<- cum_offset + offset # nolint: undesirable_operator.
                lint.R  (1 usage found)
                    670 substr(line, range[1L], range[2L]) <<- fill_with("~", range[2L] - range[1L] + 1L) # nolint: undesirable_operator.
                object_usage_linter.R  (1 usage found)
                    251 vals[[length(vals) + 1L]] <<- x # nolint: undesirable_operator.
                utils.R  (3 usages found)
                    31 res[[itr]] <<- x # nolint: undesirable_operator.
                    32 itr <<- itr + 1L # nolint: undesirable_operator.
                    177 terminal_newline <<- FALSE # nolint: undesirable_operator.
                zzz.R  (2 usages found)
                    298 default_settings <<- list( # nolint: undesirable_operator.
                    328 settings <<- list2env(default_settings, parent = emptyenv()) # nolint: undesirable_operator.

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #1767 (a89a89b) into main (7a4fcee) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1767   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files         109      109           
  Lines        4623     4623           
=======================================
  Hits         4571     4571           
  Misses         52       52           
Impacted Files Coverage Δ
R/expect_lint.R 100.00% <100.00%> (ø)
R/get_source_expressions.R 94.38% <100.00%> (ø)
R/lint.R 96.78% <100.00%> (ø)
R/object_usage_linter.R 99.39% <100.00%> (ø)
R/utils.R 98.26% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@IndrajeetPatil IndrajeetPatil merged commit 1e9b93d into main Nov 9, 2022
@IndrajeetPatil IndrajeetPatil deleted the 1766_update_linters branch November 9, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove undesirable_operator_linter from .lintr_new
3 participants