Enhance and fix indentation_linter

[AshesITR]

The issue in the reprex was xp_block_ends landed on line 1 because the comment was sitting there. It should have ended on line 2.

[AshesITR]

The R 4.2.2 release scheduled for today seems to interfere with GHA.

[AshesITR]

The condition for the double indent is very strict for now (it requires exactly the format specified in the style guide, i.e. no trailing arguments after ( and an argument before ).
This allows us to simultaneously support (single) block-indented function definitions and hanging function definitions:

# all good
function(a = 1,
         b = 2) {
  # body
}

function(
  a = 1,
  b = 2
) {
  # body
}

function(
    a = 1,
    b = 2) {
  # body
}

[AshesITR]

Filed r-lib/actions#655 for the setup-r problem.

[MichaelChirico]

I would nolint the cyclocomp issue and file a follow up to keep the logic change here easier to follow

[AshesITR]

Took me a few days to get back to it, but factoring out the indentation style XPath logic into small functions made the code easier to digest (for me, at least 🤣) and fixed the cyclocomp lint.

[codecov-commenter]

Codecov Report

Merging #1758 (b1a42b6) into main (1e9b93d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1758   +/-   ##
=======================================
  Coverage   98.87%   98.88%           
=======================================
  Files         109      109           
  Lines        4623     4653   +30     
=======================================
+ Hits         4571     4601   +30     
  Misses         52       52           

Impacted Files	Coverage Δ
R/indentation_linter.R	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[MichaelChirico]

Great stuff!