Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespace_linter() handles backticked operators #1753

Merged
merged 5 commits into from
Oct 26, 2022
Merged

Conversation

IndrajeetPatil
Copy link
Collaborator

Closes #1752

library(lintr)

lint(
  text = "magrittr::`%>%`",
  linters = namespace_linter()
)

lint(
  text = "magrittr::'%>%'",
  linters = namespace_linter()
)

Created on 2022-10-24 with reprex v2.0.2

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2022

Codecov Report

Merging #1753 (df7a8ac) into main (1ac48e9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1753   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files         109      109           
  Lines        4623     4624    +1     
=======================================
+ Hits         4571     4572    +1     
  Misses         52       52           
Impacted Files Coverage Δ
R/namespace_linter.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AshesITR AshesITR merged commit d0023d4 into main Oct 26, 2022
@AshesITR AshesITR deleted the 1752_backticked_symbols branch October 26, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

namespace_linter() false positives with re-exported functions
3 participants