Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nolint directives for undesirable_operator_linter() lints #1748

Merged
merged 6 commits into from
Oct 26, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil commented Oct 23, 2022

Waiting for #1751

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2022

Codecov Report

Merging #1748 (9993108) into main (d0023d4) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1748      +/-   ##
==========================================
- Coverage   98.87%   98.87%   -0.01%     
==========================================
  Files         109      109              
  Lines        4624     4620       -4     
==========================================
- Hits         4572     4568       -4     
  Misses         52       52              
Impacted Files Coverage Δ
R/expect_lint.R 100.00% <100.00%> (ø)
R/get_source_expressions.R 94.38% <100.00%> (ø)
R/lint.R 96.77% <100.00%> (-0.04%) ⬇️
R/object_usage_linter.R 99.39% <100.00%> (ø)
R/utils.R 98.26% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AshesITR
Copy link
Collaborator

NB you can use # nolint: undesirable_operator. as well.

R/lint.R Outdated Show resolved Hide resolved
@IndrajeetPatil
Copy link
Collaborator Author

@AshesITR This should be good for a merge. I've incorporated your suggestion.

@AshesITR AshesITR merged commit 15a9578 into main Oct 26, 2022
@AshesITR AshesITR deleted the more_nolint_directives branch October 26, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants