Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move utilities for package and project root to their own file #1743

Merged
merged 11 commits into from
Oct 24, 2022
Merged

Conversation

IndrajeetPatil
Copy link
Collaborator

Since lint.R is already quite bloated.

Since `lint.R` is already quite bloated.
DESCRIPTION Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022

Codecov Report

Merging #1743 (b716081) into main (f0b8e57) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1743   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files         108      109    +1     
  Lines        4623     4623           
=======================================
  Hits         4571     4571           
  Misses         52       52           
Impacted Files Coverage Δ
R/lint.R 96.81% <ø> (-0.27%) ⬇️
R/settings.R 97.82% <ø> (-0.69%) ⬇️
R/settings_utils.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AshesITR
Copy link
Collaborator

AshesITR commented Oct 22, 2022

The functions are related to config.R. Is there room in that file? Otherwise I'd call it config_utils.R. package_metadata_utils.R sounds like it has something to do with finding linter tags in other packages...

@IndrajeetPatil
Copy link
Collaborator Author

@AshesITR We currently don't have config.R file, so I've created config_utils.R instead.

@AshesITR
Copy link
Collaborator

Ah I meant settings.R

@IndrajeetPatil
Copy link
Collaborator Author

Gotcha. settings.R is already quite busy, so moved this to settings_utils.R instead.

@AshesITR
Copy link
Collaborator

WDYT about moving some utilities from settings.R as well (find_config() to is_directory())?

@IndrajeetPatil
Copy link
Collaborator Author

@AshesITR Moved a couple more utilities.

Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AshesITR AshesITR merged commit 1ac48e9 into main Oct 24, 2022
@AshesITR AshesITR deleted the split_lint branch October 24, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants