Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed gifs in vignettes #1742

Closed
wants to merge 4 commits into from
Closed

Embed gifs in vignettes #1742

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9735fc3
Embed gifs in vignettes
IndrajeetPatil Oct 20, 2022
de5e509
move media to figures folder
IndrajeetPatil Oct 20, 2022
f72cc98
downsize
IndrajeetPatil Oct 20, 2022
764c3f4
turn off for now
IndrajeetPatil Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
turn off for now
  • Loading branch information
@IndrajeetPatil
IndrajeetPatil committed Oct 20, 2022
commit 764c3f456174e34a90846f4088f3c1861b6846f7
4 changes: 2 additions & 2 deletions .github/workflows/R-CMD-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,5 @@ jobs:
needs: check

- uses: r-lib/actions/check-r-package@v2
with:
error-on: '"note"'
# with:
# error-on: '"note"'
Comment on lines +77 to +78
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

    happy to test this out, we may revert it slows us down a lot

Originally posted by @MichaelChirico in #1621 (review)