Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "no suggests" R CMD check workflow #1739

Merged
merged 6 commits into from
Oct 23, 2022
Merged

Conversation

IndrajeetPatil
Copy link
Collaborator

This can help us catch instances of soft dependency usage in examples or in tests without the necessary skip.

This can help us catch instances of soft dependency usage in examples or in tests without the necessary skip.
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Merging #1739 (1ea7075) into main (ee09412) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1739   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files         108      108           
  Lines        4623     4623           
=======================================
  Hits         4571     4571           
  Misses         52       52           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@IndrajeetPatil
Copy link
Collaborator Author

We will need to keep this PR updated and pending until all relevant issues to get the new check to succeed are fixed in separate PRs.

IndrajeetPatil added a commit that referenced this pull request Oct 22, 2022
@IndrajeetPatil
Copy link
Collaborator Author

The new check is green now.

Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

@AshesITR AshesITR merged commit f0b8e57 into main Oct 23, 2022
@AshesITR AshesITR deleted the add_check_no_suggests_workflow branch October 23, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants