Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve object_usage_linter() #1715

Merged
merged 5 commits into from
Oct 16, 2022

Conversation

AshesITR
Copy link
Collaborator

fixes #1714

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2022

Codecov Report

Merging #1715 (7751a95) into main (b1780c0) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1715      +/-   ##
==========================================
+ Coverage   98.75%   98.93%   +0.17%     
==========================================
  Files         105      105              
  Lines        4510     4504       -6     
==========================================
+ Hits         4454     4456       +2     
+ Misses         56       48       -8     
Impacted Files Coverage Δ
R/object_usage_linter.R 99.39% <100.00%> (+4.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

R/object_usage_linter.R Outdated Show resolved Hide resolved
R/object_usage_linter.R Outdated Show resolved Hide resolved
R/object_usage_linter.R Outdated Show resolved Hide resolved
@MichaelChirico
Copy link
Collaborator

High-level feedback -- the NEWS bullet is great, but I really couldn't figure out what's going on from the original issue description (#1714), consider going back and adding a quick summary reprex at the top for posterity

@AshesITR
Copy link
Collaborator Author

Moved the reprex around and expanded the checkUsage one so both have the same code. That should make it much easier to see the problem.

@IndrajeetPatil IndrajeetPatil merged commit 7aee482 into main Oct 16, 2022
@IndrajeetPatil IndrajeetPatil deleted the fix/1714-object_usage-ignored-warnings branch October 16, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not all usage issues reported back to user
4 participants