Wherever possible, prefer expect_identical() over expect_equal()
#1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1712 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 104 104
Lines 4497 4497
=======================================
Hits 4442 4442
Misses 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tests/testthat/test-methods.R
Outdated
| df, | ||
| exp | ||
| ) | ||
| expect_equal(df, exp) |
There was a problem hiding this comment.
what's going on here? 🙃
There was a problem hiding this comment.
df columns are not of integer type here:
── Failure (test-methods.R:74): as.data.frame.lints ────────────────────────────
`df` (`actual`) not identical to `exp` (`expected`).
`actual$line_number` is a double vector (1, 2)
`expected$line_number` is an integer vector (1, 2)
`actual$column_number` is a double vector (1, 6)
`expected$column_number` is an integer vector (1, 6)There was a problem hiding this comment.
Was going to fix it in a different PR, but might as well do it here.
There was a problem hiding this comment.
thanks, I would have suggested just leaving the style fix for that other PR
There was a problem hiding this comment.
So should I undo this here?
There was a problem hiding this comment.
no it's fine, minor point here
MichaelChirico
approved these changes
Oct 15, 2022
|
madman, you actually did it! 🤟🤟 |
expect_identical_linter() lintsexpect_identical() over expect_equal()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.